Tiago Pascoal

The only person who can truly persuade you is yourself. You must turn the issues over in your mind at leisure, consider the many arguments, let them simmer, and after a long time turn your preferences into convictions.
Milton Friedman
posts - 99, comments - 42, trackbacks - 32

Your Code Sucks and I Hate You

Did the title catch your attention? Well it did mine.

It is the title of a post that I've just read. Although the title seems a little bit trolish it's because it probably is, if you read the subtitle you will see the main title is not only trollish but very misleading. The post subtitle is The Social Dynamics of Code Reviews.

It mainly talks about code reviews in open source projects but most of the knowledge sprung in this post is applicable to close source projects.

 

Code reviews is something that is hard to do effectively. Even you get past the sociological issues mentioned on the post, without a decent tool it is very hard to keep track what has been reviewed and it's not.

Code review is one of the area I wish there were some kind of offering for TFS. Granted you can do code reviews with shelve sets and some sort of informal communication via email (assigning code review tasks or even a work item type) but that would give us no metrics or a simple way to keep track which parts of the code have been reviewed.

 

The more complete solution for TFS seems to be TeamReview (freely available on codeplex) which combines specific work item types and a Visual Studio add-in to help you manage the process. While I never tested the tool, I've given some attention to the description and workflow and it seems to work at a very micro level of the code. And the metric tools (what has been reviewed, what is not, etc,etc) seems to be non existant.

 

There are some more mature solutions that perhaps can be adapted to be used with TFS:

  • Review board which has originated from VMware
  • The venerable Codestriker
  • JCR - which unlike other tools doesn't work at the source control level but with whole files

 

On the commercial side Code Collaborator from Smart Bear has a good reputation and it works with TFS but never tried it either.

Print | posted on Sunday, December 28, 2008 8:56 PM

Feedback

# Your Code Sucks and I Hate You

Did the title catch your attention? Well it did mine. It is the title of a post that I've just read .
12/28/2008 4:03 PM | Tiago Pascoal

# VSTS Links - 01/02/2009

Tiago Pascoal on Your Code Sucks and I Hate You Willy-Peter Schaub on TFS/VSTS 2008 Images - Imminent...
1/2/2009 5:06 AM | Team System News
Gravatar

# TeamReview - Better Social Dynamics in Code Review

The larger compelling argument that Tiago makes so subtly and accurately is that there are successful code review tools to emulate that create continuous business improvements by leveraging under-valued existing feedback channels in the software development process. These same feedback channels are there for the taking for Team System users, like anyone else creating software, so long as there is a business advantage for doing so. Creating that advantage is where Team System's OOTB offering falls short and where TeamReview shines.

1/8/2009 4:01 AM | JB Brown

# Malevich

Malevich
1/11/2009 3:53 AM | Tiago Pascoal

# Malevich – A new code review system

  In a previous post i slightly grasped (actually just pointed to a good post) about the dynamic
1/11/2009 4:03 AM | Tiago Pascoal

Post Comment

Title  
Name  
Email
Url
Comment   

Powered by: